Undeprecating DBApiHookForTests._make_common_data_structure
#38573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
approved these changes
Mar 27, 2024
potiuk
approved these changes
Mar 27, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Undeprecating `DBApiHookForTests._make_common_data_structure` * Add missing db_test marker (cherry picked from commit b06f401)
ephraimbuddy
added
the
changelog:skip
mathiaHT
pushed a commit
to mathiaHT/airflow
that referenced
this pull request
Apr 4, 2024
…#38573) * Undeprecating `DBApiHookForTests._make_common_data_structure` * Add missing db_test marker
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…#38573) * Undeprecating `DBApiHookForTests._make_common_data_structure` * Add missing db_test marker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36876 - incorrectly deprecate invalid method
DBApiHookForTests._make_common_data_structureintends to be overwritten into the subclasses, and error should be raised only in case if subclass implements_make_serializablePython be like
Found during #38504, thanks @dstandish to point what is wrong here
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.