Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide internals of some groupped workflows #38604

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 29, 2024

When the whole workflow can be skipped and it's one of the workflows than nothing depends on, we can skip the whole workflow rather than individual jobs - then the workflow will not be shown as unfolded with all the jobs skipped but as a single skipped workflow.

This is what we do for Additional CI image tests and Finalize tests & Special tests


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2024

Avoids this:

Screenshot 2024-03-29 at 02 18 58

@potiuk potiuk force-pushed the hide-internals-of-skipped-workflows branch 2 times, most recently from 00c3bf2 to 69cc522 Compare March 29, 2024 01:37
@potiuk potiuk added the upgrade to newer dependencies If set, upgrade to newer dependencies is forced label Mar 29, 2024
@potiuk potiuk closed this Mar 29, 2024
@potiuk potiuk reopened this Mar 29, 2024
@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2024

Reopened to check with upgrade-to-newer-dependencies.

@potiuk potiuk force-pushed the hide-internals-of-skipped-workflows branch 2 times, most recently from 4a01cd9 to 04567fe Compare March 29, 2024 13:23
@potiuk potiuk requested a review from jscheffl March 29, 2024 13:25
@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2024

Should be good to go - seems to pass all the variants

Copy link
Collaborator

@aritra24 aritra24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a question, but overall looks good

.github/workflows/special-tests.yml Outdated Show resolved Hide resolved
@potiuk potiuk added full tests needed We need to run full set of tests for this PR to merge and removed upgrade to newer dependencies If set, upgrade to newer dependencies is forced labels Mar 29, 2024
@potiuk potiuk force-pushed the hide-internals-of-skipped-workflows branch 3 times, most recently from 61ec66d to 7187a29 Compare March 29, 2024 13:53
When the whole workflow can be skipped and it's one of the workflows
than nothing depends on, we can skip the whole workflow rather than
individual jobs - then the workflow will not be shown as unfolded
with all the jobs skipped but as a single skipped workflow.

This is what we do for Additional CI image tests and Finalize tests
& special tests.
@potiuk potiuk force-pushed the hide-internals-of-skipped-workflows branch from 7187a29 to d9ba732 Compare March 29, 2024 13:53
@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2024

Merging. the "No pydantic" tests in main will be handled separately (need to skip some more tests in NoPydantic case).

@potiuk potiuk merged commit 3f4872b into apache:main Mar 29, 2024
63 of 64 checks passed
@potiuk potiuk deleted the hide-internals-of-skipped-workflows branch March 29, 2024 14:34
mathiaHT pushed a commit to mathiaHT/airflow that referenced this pull request Apr 4, 2024
When the whole workflow can be skipped and it's one of the workflows
than nothing depends on, we can skip the whole workflow rather than
individual jobs - then the workflow will not be shown as unfolded
with all the jobs skipped but as a single skipped workflow.

This is what we do for Additional CI image tests and Finalize tests
& special tests.
ephraimbuddy pushed a commit that referenced this pull request Apr 16, 2024
When the whole workflow can be skipped and it's one of the workflows
than nothing depends on, we can skip the whole workflow rather than
individual jobs - then the workflow will not be shown as unfolded
with all the jobs skipped but as a single skipped workflow.

This is what we do for Additional CI image tests and Finalize tests
& special tests.

(cherry picked from commit 3f4872b)
ephraimbuddy pushed a commit that referenced this pull request Apr 16, 2024
When the whole workflow can be skipped and it's one of the workflows
than nothing depends on, we can skip the whole workflow rather than
individual jobs - then the workflow will not be shown as unfolded
with all the jobs skipped but as a single skipped workflow.

This is what we do for Additional CI image tests and Finalize tests
& special tests.

(cherry picked from commit 3f4872b)
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
When the whole workflow can be skipped and it's one of the workflows
than nothing depends on, we can skip the whole workflow rather than
individual jobs - then the workflow will not be shown as unfolded
with all the jobs skipped but as a single skipped workflow.

This is what we do for Additional CI image tests and Finalize tests
& special tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants