Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator #38716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amRunPythonPipelineOperator
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
eladkal
reviewed
Apr 3, 2024
zstrathe
force-pushed
the
BeamPythonBugfix
branch
from
6c8ca7b
to
3036c0e
Compare
e-galan
reviewed
Apr 8, 2024
…nPipelineOperator to ensure that GCSHook is only called when necessary
zstrathe
commented
Apr 15, 2024
e-galan
reviewed
Apr 16, 2024
…ok 'gs://' arg prefixes
potiuk
approved these changes
Apr 18, 2024
eladkal
approved these changes
Apr 18, 2024
|
Static checks need fixing. |
|
@potiuk Static checks should pass now. I sincerely apologize for that, I'll ensure to run pre-commit checks for any future contributions. |
|
Nothing to be sorry about :) |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
…amRunPythonPipelineOperator (apache#38716) * Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator * remove unneccary check for GCSHook and add unit test for BeamRunPythonPipelineOperator to ensure that GCSHook is only called when necessary * Split out unit tests for TestBeamRunPythonPipelineOperator with GCSHook 'gs://' arg prefixes * Fix formatting
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…amRunPythonPipelineOperator (apache#38716) * Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator * remove unneccary check for GCSHook and add unit test for BeamRunPythonPipelineOperator to ensure that GCSHook is only called when necessary * Split out unit tests for TestBeamRunPythonPipelineOperator with GCSHook 'gs://' arg prefixes * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #38713 by modifying BeamRunPythonPipelineOperator.execute_sync() to only call GCSHook when necessary
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.