Amazon Bedrock - Clean up hook unit tests #38849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
Taragolis
approved these changes
Apr 9, 2024
vincbeck
approved these changes
Apr 9, 2024
o-nikolas
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincbeck and @Taragolis requested some changes to the Bedrock hooks in #38693 and I missed the opportunity to greatly simplify the related unit tests.
The fixture and the two "constants" were only used by tests which were removed after Vincent's suggestion and should have been removed when the tests were. Once they were gone, I saw a much cleaner way to consolidate the remaining tests.
Static checks for it are currently failing locally but it looks like an issue with
tests/providers/common/sql/test_utils.py:45:and it looks like @Taragolis and @dondaum are maybe working on that?^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.