-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph view improvements #38940
Merged
Merged
Graph view improvements #38940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Apr 11, 2024
I'd prefer zooming out vs introducing a toggle for this. |
jedcunningham
approved these changes
Apr 16, 2024
5476b0e
to
e6094c5
Compare
2 tasks
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Initial pass at graph updates again * Initial pass * fixes * Fix task_group tests
jedcunningham
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Initial pass at graph updates again * Initial pass * fixes * Fix task_group tests (cherry picked from commit 0fbe711)
56 tasks
2 tasks
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
* Initial pass at graph updates again * Initial pass * fixes * Fix task_group tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
type:bug-fix
Changelog: Bug Fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text was getting cut off too many times for graph view nodes. The zoomed out version was also hard to read.
Before:
![Screenshot 2024-04-11 at 1 14 15 PM](https://private-user-images.githubusercontent.com/4600967/321722081-6c93cb8a-b970-4de0-b2ec-9310405f1dd7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1OTE5MDEsIm5iZiI6MTcyMTU5MTYwMSwicGF0aCI6Ii80NjAwOTY3LzMyMTcyMjA4MS02YzkzY2I4YS1iOTcwLTRkZTAtYjJlYy05MzEwNDA1ZjFkZDcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjFUMTk1MzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjdlOGEzMGFlMGE2ZmQxOGQyNmY0YTIxMjc2OGUxNTc5ZDk0NGE3NmY5ODJjMTAwN2RkYWUxNmNjM2U2YjExMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.TzWzDxQOR0zS0PsJZ_ntsmopzZTsyyF7IK0J9gvlVfU)
![Screenshot 2024-04-11 at 1 14 10 PM](https://private-user-images.githubusercontent.com/4600967/321722082-b995506d-d5db-49bd-ba27-c75d119d60c1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1OTE5MDEsIm5iZiI6MTcyMTU5MTYwMSwicGF0aCI6Ii80NjAwOTY3LzMyMTcyMjA4Mi1iOTk1NTA2ZC1kNWRiLTQ5YmQtYmEyNy1jNzVkMTE5ZDYwYzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjFUMTk1MzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDcxYTc1OTQzZWY2MjgxNjMzZDMwZDYwYzhlOTM2ZTQzMjRkZGZiMzZmMDc0ZGMwNjIwMjg4YTJiNjNjNGI0MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.819GkG3_zjtQWsTRHolcXr7OVucxFuyEFDEJW7pKVvw)
After:
![Screenshot 2024-04-11 at 1 02 15 PM](https://private-user-images.githubusercontent.com/4600967/321722085-f32302e0-dbd2-4e7b-9905-7b68f5b431cd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1OTE5MDEsIm5iZiI6MTcyMTU5MTYwMSwicGF0aCI6Ii80NjAwOTY3LzMyMTcyMjA4NS1mMzIzMDJlMC1kYmQyLTRlN2ItOTkwNS03YjY4ZjViNDMxY2QucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjFUMTk1MzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGNkZTU5Y2VkNTU0NzdkMTY4NWU2NDQ5N2E4MDdkYTVkMmRmNmMyYzZmMTkzZGNmOGY1M2E5ZWE2NzI5MjMwMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.NxBeV8_9l4dR_jwt0jlrTwt8Er_E8t26lhwyztqm5IQ)
![Screenshot 2024-04-11 at 1 02 12 PM](https://private-user-images.githubusercontent.com/4600967/321722086-bfe616cd-275a-420f-a680-35f39d847880.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1OTE5MDEsIm5iZiI6MTcyMTU5MTYwMSwicGF0aCI6Ii80NjAwOTY3LzMyMTcyMjA4Ni1iZmU2MTZjZC0yNzVhLTQyMGYtYTY4MC0zNWYzOWQ4NDc4ODAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjFUMTk1MzIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTBmZDg3Y2M5ODY3ODRkMWI4MzZkNTVjNWRlNzIyZTU1OGNlMWMyMGZjMGY0YTQ0NjY5ZjNiYWY4OWU5MDZiYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.TIdQ8wAgzX76uwhQsTD9nOqNxI8aQGvAmM-ik9qt6hU)
Two questions:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.