Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph view improvements #38940

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Conversation

bbovenzi
Copy link
Contributor

The text was getting cut off too many times for graph view nodes. The zoomed out version was also hard to read.

Before:
Screenshot 2024-04-11 at 1 14 15 PM
Screenshot 2024-04-11 at 1 14 10 PM

After:
Screenshot 2024-04-11 at 1 02 15 PM
Screenshot 2024-04-11 at 1 02 12 PM

Two questions:

  • Should the simplified mode happen automatically when zooming out, or by toggling a checkbox?
  • What other information would people find useful to include in the details node view?

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.1 milestone Apr 11, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 11, 2024
@jedcunningham
Copy link
Member

Should the simplified mode happen automatically when zooming out, or by toggling a checkbox?

I'd prefer zooming out vs introducing a toggle for this.

@bbovenzi bbovenzi merged commit 0fbe711 into apache:main Apr 17, 2024
42 checks passed
@bbovenzi bbovenzi deleted the graph-view-improvements branch April 17, 2024 13:00
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* Initial pass at graph updates again

* Initial pass

* fixes

* Fix task_group tests
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 26, 2024
jedcunningham pushed a commit that referenced this pull request Apr 26, 2024
* Initial pass at graph updates again

* Initial pass

* fixes

* Fix task_group tests

(cherry picked from commit 0fbe711)
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
* Initial pass at graph updates again

* Initial pass

* fixes

* Fix task_group tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants