Fix dag run selection #38941
Merged
Fix dag run selection #38941
+39
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
aritra24
approved these changes
Apr 11, 2024
dstandish
approved these changes
Apr 11, 2024
eladkal
approved these changes
Apr 11, 2024
Closed
2 tasks
This was referenced Apr 18, 2024
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Fix dag run link params * Do run_id checks inside of the grid_data hook * remove firstRunId context
jedcunningham
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Fix dag run link params * Do run_id checks inside of the grid_data hook * remove firstRunId context (cherry picked from commit f87772f)
56 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38939
We added logic to change the date filters for the grid data when the selected run_id was out of range. But that created its own issue that if you refreshed the page, we could change the runs returned and there was no way to reset the page.
Mixing
run_idas a url parameter and as an API param led to a messy source of truth. Now all of these checks happen during the grid_data request. We check if the run_id is within the current response. If not, we check against the API if the run_id is valid. If it is not valid, we remove the run_id selection. Otherwise, we update the base_date with the run's execution_date and refetch the grid_data.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.