Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate BaseXCom.get_one method #38991

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Taragolis
Copy link
Contributor

I guess BaseXCom.get_one is deprecated by a mistake in #37058

{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/operators/test_trigger_dagrun.py::TestDagRunOperator::test_trigger_dagrun", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/operators/test_trigger_dagrun.py::TestDagRunOperator::test_trigger_dagrun_with_execution_date", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/operators/test_trigger_dagrun.py::TestDagRunOperator::test_trigger_dagrun_twice", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/operators/test_trigger_dagrun.py::TestDagRunOperator::test_trigger_dagrun_with_scheduled_dag_run", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/operators/test_trigger_dagrun.py::TestDagRunOperator::test_trigger_dagrun_with_templated_execution_date", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/operators/test_trigger_dagrun.py::TestDagRunOperator::test_trigger_dagrun_triggering_itself", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_pools. (Use Pool.get_pools() instead) -- Deprecated since version 2.2.4.", "node_id": "tests/api_experimental/auth/backend/test_basic_auth.py::TestBasicAuth::test_success", "filename": "airflow/www/api/experimental/endpoints.py", "lineno": 366}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_pools. (Use Pool.get_pools() instead) -- Deprecated since version 2.2.4.", "node_id": "tests/api_experimental/auth/backend/test_basic_auth.py::TestBasicAuth::test_experimental_api", "filename": "airflow/www/api/experimental/endpoints.py", "lineno": 366}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/api_connexion/endpoints/test_extra_link_endpoint.py::TestGetExtraLinks::test_should_respond_200", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/api_connexion/endpoints/test_extra_link_endpoint.py::TestGetExtraLinks::test_should_respond_200_missing_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/api_connexion/endpoints/test_extra_link_endpoint.py::TestGetExtraLinks::test_should_respond_200_multiple_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/api_connexion/endpoints/test_extra_link_endpoint.py::TestGetExtraLinks::test_should_respond_200_multiple_links_missing_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/api_connexion/endpoints/test_extra_link_endpoint.py::TestGetExtraLinks::test_should_respond_200_support_plugins", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_athena.py::TestAthenaQueryResultsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_athena.py::TestAthenaQueryResultsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_batch.py::TestBatchJobDefinitionLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_batch.py::TestBatchJobDefinitionLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_batch.py::TestBatchJobDetailsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_batch.py::TestBatchJobDetailsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_batch.py::TestBatchJobQueueLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_batch.py::TestBatchJobQueueLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrClusterLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrClusterLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrLogsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrLogsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrLogsLink::test_missing_log_url", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessLogsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessLogsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessDashboardLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessDashboardLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessS3LogsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessS3LogsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessCloudWatchLogsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_emr.py::TestEmrServerlessCloudWatchLogsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_glue.py::TestGlueJobRunDetailsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_glue.py::TestGlueJobRunDetailsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_logs.py::TestCloudWatchEventsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_logs.py::TestCloudWatchEventsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_step_function.py::TestStateMachineDetailsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_step_function.py::TestStateMachineDetailsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_step_function.py::TestStateMachineExecutionsDetailsLink::test_empty_xcom", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/amazon/aws/links/test_step_function.py::TestStateMachineExecutionsDetailsLink::test_extra_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryOperator::test_bigquery_operator_extra_serialized_field_when_single_query", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryOperator::test_bigquery_operator_extra_serialized_field_when_multiple_queries", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryOperator::test_bigquery_operator_extra_link_when_missing_job_id", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryOperator::test_bigquery_operator_extra_link_when_single_query", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryOperator::test_bigquery_operator_extra_link_when_multiple_query", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_create_cluster_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_scale_cluster_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_submit_job_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_update_cluster_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_instantiate_workflow_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_instantiate_inline_workflow_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/google/cloud/operators/test_dataproc.py::test_submit_spark_job_operator_extra_links", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/cncf/kubernetes/operators/test_pod.py::TestKubernetesPodOperator::test_push_xcom_pod_info", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/common/io/xcom/test_backend.py::TestXComObjectStorageBackend::test_value_db", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/common/io/xcom/test_backend.py::TestXComObjectStorageBackend::test_value_storage", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/common/io/xcom/test_backend.py::TestXComObjectStorageBackend::test_compression", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/dbt/cloud/operators/test_dbt.py::TestDbtCloudRunJobOperator::test_run_job_operator_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/microsoft/azure/operators/test_data_factory.py::TestAzureDataFactoryRunPipelineOperator::test_run_pipeline_operator_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
{"category": "DeprecationWarning", "message": "Call to deprecated function (or staticmethod) get_one.", "node_id": "tests/providers/microsoft/azure/operators/test_synapse.py::TestAzureSynapseRunPipelineOperator::test_run_pipeline_operator_link", "filename": "airflow/api_internal/internal_api_call.py", "lineno": 127}
...

cc: @bolkedebruin


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis added this to the Airflow 2.9.1 milestone Apr 13, 2024
@Taragolis Taragolis added the type:bug-fix Changelog: Bug Fixes label Apr 13, 2024
@bolkedebruin
Copy link
Contributor

Probably indeed. I think it was done as XCom is messy and the get_one method really should be deprecated eventually, but it's a bit early.

@bolkedebruin bolkedebruin merged commit 260d3fd into apache:main Apr 15, 2024
42 checks passed
@Taragolis Taragolis deleted the undeprecate-basexcom-get-one branch April 15, 2024 10:48
@dstandish
Copy link
Contributor

Maybe whoever deprecated just forgot to update the code that depends on it to use something else?

@bolkedebruin
Copy link
Contributor

I was the culprit @dstandish and no, I didn't :-) ( cause of the direction the PR was going )

utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
jedcunningham pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants