-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pass airflow confi as job param #39007
base: main
Are you sure you want to change the base?
Feature/pass airflow confi as job param #39007
Conversation
@dirrao Let me know if it makes more sense to add a flag "import_airflow_config" and when it is True then set airflow config as job_params in databricks jobs. |
job_params = self.params.items() if self.params.items() else {} | ||
param_list = [] | ||
for k, v in job_params: | ||
param_list.append({"name": k, "default": v}) | ||
self.json["parameters"] = param_list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job_params = self.params.items() if self.params.items() else {} | |
param_list = [] | |
for k, v in job_params: | |
param_list.append({"name": k, "default": v}) | |
self.json["parameters"] = param_list | |
if self.params.items() is not None: | |
self.json["parameters"] = [{"name": k, "default": v} for for k, v in self.params.items()] | |
else: | |
self.json["parameters"] = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this self.params
from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are airflow configs
Fixes: #39002
Tests: