-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "check whether AUTH_ROLE_PUBLIC is set in check_authentication… #39009
Conversation
…apache#38924)" This reverts commit 7b60825.
Hey @Lee-W - this PR has a side effect on failing a number of tests in
By a quick look, change from 401 -> 403 impacts all the cases where unauthanticated user is used, which I think is not an intended behaviour (the original isssue mentions only AUTH_ROLE_PUBLIC case). So rather than fixing all 401 in 403 - I think it's better to revert it now and fix it "properly" (which also means that |
The PR to run FAB tests together with API changes is merged now @Lee-W -> so you should be able to redo the PR and see the tess failing in your PR. The "too selective" case should be now nicely covered. |
apache#38924)" (apache#39009) This reverts commit 7fc2169.
Sure. I just addressed the issue, created a new PR #39012, and added the required label. Thanks for reminding me! |
apache#38924)" (apache#39009) This reverts commit 7fc2169.
Sorry for the troubles with selective checs :( . But should be fixed from now on. |
Not at all. Thanks for the fix 🙂 |
…apache#38924)" (apache#39009) This reverts commit 7b60825.
… (#38924)"
This reverts commit 7b60825.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.