Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ImportError for KubernetesDeleteJobOperator in google provider #39036

Merged

Conversation

vatsrahul1001
Copy link
Collaborator

@vatsrahul1001 vatsrahul1001 commented Apr 15, 2024

PR #37793 introduced KubernetesDeleteJobOperator in the latest release
8.1.0 of the cncf-kubernetes provider, which is also a dependency
for the latest release of the google provider 10.17.0.
As a result, google provider 10.17.0 raises an ImportError for the optional
provider cncf-kubernetes dependency for versions <8.1.0. This PR resolves
this issue by suggesting with an AirflowOptionalProviderFeatureException
to upgrade the optional provider version to >=8.1.0


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues labels Apr 15, 2024
@vatsrahul1001 vatsrahul1001 marked this pull request as draft April 15, 2024 16:40
@pankajkoti pankajkoti changed the title Handling import of KubernetesDeleteJobOperator Handle ImportError for KubernetesDeleteJobOperator in google provider Apr 15, 2024
@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review April 15, 2024 16:57
@potiuk potiuk merged commit 0c630fa into apache:main Apr 15, 2024
41 checks passed
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants