AIP-61: Allow multiple executors to load their CLI commands #39077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syedahsn
requested review from
kaxil,
XD-DENG,
ashb,
o-nikolas,
pierrejeambrun and
hussein-awala
as code owners
boring-cyborg
bot
added
area:CLI
area:Executors-core
syedahsn
commented
Apr 16, 2024
vincbeck
approved these changes
Apr 17, 2024
o-nikolas
changed the title
o-nikolas
reviewed
Apr 17, 2024
… Executor fails to load Add unit test to test failure to load Executor case Remove import_all_executors and associated unit test
o-nikolas
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executors are able to vend custom CLI commands to the Airflow CLI. In order to support multiple Executors, we need to allow each configured Executor to vend its set of CLI commands.
This PR introduces a method to load all Executor specific CLI commands, as well as associated unit tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.