Replace pod_manager.read_pod_logs with client.read_namespaced_pod_log in KubernetesPodOperator._write_logs #39112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Lee-W
force-pushed
the
simplify-kpo-write-logs-logic
branch
from
6552b38
to
df0b6fe
Compare
|
I'll hold this for some time. I will prepare it for review when I finish all the implementations. |
Lee-W
force-pushed
the
simplify-kpo-write-logs-logic
branch
from
df0b6fe
to
07826ef
Compare
Lee-W
changed the title
romsharon98
approved these changes
May 2, 2024
eladkal
approved these changes
May 2, 2024
Lee-W
force-pushed
the
simplify-kpo-write-logs-logic
branch
from
07826ef
to
8c8179e
Compare
Lee-W
force-pushed
the
simplify-kpo-write-logs-logic
branch
from
8c8179e
to
6a2c750
Compare
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
… in KubernetesPodOperator._write_logs (apache#39112) * style(cncf): add type annotation and remove redundant else-block * refactor(cncf): move deprecated method to the end for better readability * style(cncf): use f-string instead of string concatenation * refactor(cncf): reduce one comparison for should_delete_pod * refactor(cncf): rename write_logs as _write_logs * refactor(cncf): move read_pod_logs logic to _write_logs * test(cncf): unify mock.patch as patch
This was referenced May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back the changes in #36228 and improve the type annotation.
As mentioned in #36228, we don't really need to call
pod_manager.read_pod_logsand could callclient.read_namespaced_pod_logdirectly instead^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.