Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task filtering UX #39119

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

bbovenzi
Copy link
Contributor

Continuation of #38660

It was not always obvious if the DAG page was being filtered by the upstream/downstream of a task. A few fixes:

  • if a filter is applied, make the button blue
  • if a filter is applied, display the dropdown regardless of task/run selection
  • update copy
  • don't show map index in breadrcrumb if it is -1
Screenshot 2024-04-18 at 12 15 14 PM Screenshot 2024-04-18 at 12 14 58 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.1 milestone Apr 18, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 18, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

airflow/www/static/js/dag/details/Header.tsx Show resolved Hide resolved
@bbovenzi bbovenzi merged commit 596e9ea into apache:main Apr 22, 2024
39 checks passed
@bbovenzi bbovenzi deleted the improve-task-filters branch April 22, 2024 14:15
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 26, 2024
jedcunningham pushed a commit that referenced this pull request Apr 26, 2024
* Improve filtering grid/graph/gantt filtering by task UX

* only show map index if greater than -1

(cherry picked from commit 596e9ea)
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
* Improve filtering grid/graph/gantt filtering by task UX

* only show map index if greater than -1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants