Use grid view for Task Instance's log_url
#39183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AetherUnbound
force-pushed
the
fix/task-instance-log-url
branch
from
aaf13bb
to
83c6d27
Compare
|
LGTM but deferring to @bbovenzi |
bbovenzi
approved these changes
Apr 23, 2024
bbovenzi
requested changes
Apr 23, 2024
|
@bbovenzi there's one test that's failing but it looks like it might be a flakey one, would you mind re-running it? |
bbovenzi
approved these changes
Apr 24, 2024
jedcunningham
pushed a commit
that referenced
this pull request
Apr 26, 2024
56 tasks
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
* Use grid view for Task Instance's `log_url` * Update other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #39023, #39179
This PR changes the Task Instance's
log_urlto use the logs tab of the Grid view UI, rather than the/logpage for the specific task instance result.