Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve helm chart annotation building script #39286

Merged

Conversation

jedcunningham
Copy link
Member

Very minor improvement, but this gets rid of a bunch of extra newlines and properly indents the annotations, allowing for an append redirect right into Chart.yaml.

Before:

$ python3 ./dev/chart/build_changelog_annotations.py
- description: Don't overwrite ``.Values.airflowPodAnnotations``
  kind: fixed
  links:
  - name: '#37917'
    url: https://github.com/apache/airflow/pull/37917

- description: Fix cluster-wide RBAC naming clash when using multiple ``multiNamespace``
    releases with the same name
  kind: fixed
  links:
  - name: '#37197'
    url: https://github.com/apache/airflow/pull/37197

- description: 'Misc: Default airflow version to 2.8.3'
  kind: changed
  links:
  - name: '#38036'
    url: https://github.com/apache/airflow/pull/38036

After:

$ python3 ./dev/chart/build_changelog_annotations.py                 
    - description: Don't overwrite ``.Values.airflowPodAnnotations``
      kind: fixed
      links:
      - name: '#37917'
        url: https://github.com/apache/airflow/pull/37917
    - description: Fix cluster-wide RBAC naming clash when using multiple ``multiNamespace``
        releases with the same name
      kind: fixed
      links:
      - name: '#37197'
        url: https://github.com/apache/airflow/pull/37197
    - description: 'Misc: Default airflow version to 2.8.3'
      kind: changed
      links:
      - name: '#38036'
        url: https://github.com/apache/airflow/pull/38036

Very minor improvement, but this gets rid of a bunch of extra newlines
and properly indents the annotations, allowing for an append redirect
right into Chart.yaml.
@jedcunningham jedcunningham merged commit 60b17bb into apache:main Apr 27, 2024
68 checks passed
@jedcunningham jedcunningham deleted the improve_chart_annotation_generator branch April 27, 2024 13:55
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
Very minor improvement, but this gets rid of a bunch of extra newlines
and properly indents the annotations, allowing for an append redirect
right into Chart.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants