-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct prefixes for distribution packages in provider documentation #39341
Use correct prefixes for distribution packages in provider documentation #39341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like this is due to recent pip support for underscore in packager names. isn't it same thing applies to all the providers?
This one about normalisation described in PEP-625 and wheel specification Due to normalisation in distribution files all Some demonstration by Python 3.9.10 (main, Feb 25 2022, 16:54:01)
[Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from packaging.utils import parse_sdist_filename, parse_wheel_filename
>>>
>>>
>>> parse_sdist_filename("apache-airflow-providers-apache-flink-1.3.0.tar.gz")
('apache-airflow-providers-apache-flink', <Version('1.3.0')>)
>>> parse_sdist_filename("apache_airflow_providers_apache_flink-1.3.0.tar.gz")
('apache-airflow-providers-apache-flink', <Version('1.3.0')>)
>>>
>>>
>>> parse_wheel_filename("apache_airflow_providers_apache_flink-1.3.0-py3-none-any.whl")
('apache-airflow-providers-apache-flink', <Version('1.3.0')>, (), frozenset({<py3-none-any @ 4308247616>}))
>>> parse_wheel_filename("apache-airflow-providers-apache-flink-1.3.0-py3-none-any.whl")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/taragolis/.pyenv/versions/airflow-dev-env-39/lib/python3.9/site-packages/packaging/utils.py", line 114, in parse_wheel_filename
raise InvalidWheelFilename(
packaging.utils.InvalidWheelFilename: Invalid wheel filename (wrong number of parts): apache-airflow-providers-apache-flink-1.3.0-py3-none-any
>>> Previously we use
Yes, this applied to all providers. |
Follow-up after a few recent changes in provider templates. The template changes from apache#39552 have not been applied to the new apache.iceberg provider. Also we are preparing to re-release providers with 2.7.0 compatibility and there was a change in naming of packages updated in the provider doucmentation naming convention that has not been reflected in generated index and fixed in apache#39341 - but it has not been applied to all the providers. This PR is a result of `breeze release-management prepare-provider-documentation --reapply-templates-only` that is supposed to consistently apply template changes to all providers.
Follow-up after a few recent changes in provider templates. The template changes from apache#39552 have not been applied to the new apache.iceberg provider. Also we are preparing to re-release providers with 2.7.0 compatibility and there was a change in naming of packages updated in the provider doucmentation naming convention that has not been reflected in generated index and fixed in apache#39341 - but it has not been applied to all the providers. This PR is a result of `breeze release-management prepare-provider-documentation --reapply-templates-only` that is supposed to consistently apply template changes to all providers.
Follow-up after a few recent changes in provider templates. The template changes from apache#39552 have not been applied to the new apache.iceberg provider. Also we are preparing to re-release providers with 2.7.0 compatibility and there was a change in naming of packages updated in the provider doucmentation naming convention that has not been reflected in generated index and fixed in apache#39341 - but it has not been applied to all the providers. This PR is a result of `breeze release-management prepare-provider-documentation --reapply-templates-only` that is supposed to consistently apply template changes to all providers.
Follow-up after a few recent changes in provider templates. The template changes from #39552 have not been applied to the new apache.iceberg provider. Also we are preparing to re-release providers with 2.7.0 compatibility and there was a change in naming of packages updated in the provider doucmentation naming convention that has not been reflected in generated index and fixed in #39341 - but it has not been applied to all the providers. This PR is a result of `breeze release-management prepare-provider-documentation --reapply-templates-only` that is supposed to consistently apply template changes to all providers.
Follow-up after a few recent changes in provider templates. The template changes from apache#39552 have not been applied to the new apache.iceberg provider. Also we are preparing to re-release providers with 2.7.0 compatibility and there was a change in naming of packages updated in the provider doucmentation naming convention that has not been reflected in generated index and fixed in apache#39341 - but it has not been applied to all the providers. This PR is a result of `breeze release-management prepare-provider-documentation --reapply-templates-only` that is supposed to consistently apply template changes to all providers.
Since we change build packages to hatch it also affects name of distribution packages,
previously it use
-
in sdist package prefix, however now it use_
for bothsdist
andwheel
distributionsapache_airflow_providers_apache_flink-1.3.0.dev0.tar.gz
apache_airflow_providers_apache_flink-1.3.0.dev0-py3-none-any.whl
More generic solution rather than: #39305
diff after local run
breeze release-management prepare-provider-documentation apache.flink --reapply-templates-only
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.