Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD prototype version dark mode for Airflow UI #39355

Merged
merged 22 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow/www/static/css/bootstrap-theme.css
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,24 @@ html {
-ms-text-size-adjust: 100%;
-webkit-text-size-adjust: 100%;
}
html[data-color-scheme="dark"] {
filter: invert(100%) hue-rotate(180deg);
}
html[data-color-scheme="dark"] #dark_icon {
display: block;
}
html[data-color-scheme="dark"] #light_icon {
display: none;
}
html[data-color-scheme="light"] {
/* not do */
}
html[data-color-scheme="light"] #dark_icon {
display: none;
}
html[data-color-scheme="light"] #light_icon {
display: block;
}
body {
margin: 0;
}
Expand Down
46 changes: 46 additions & 0 deletions airflow/www/static/js/toggle_theme.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/*!
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

/* global document, localStorage */

const STORAGE_THEME_KEY = "darkTheme";
const HTML_THEME_DATASET_KEY = "data-color-scheme";
const HTML = document.documentElement;
const TOGGLE_BUTTON_ID = "themeToggleButton";

const getJsonFromStorage = (key) => JSON.parse(localStorage.getItem(key));
const updateTheme = (isDark) => {
localStorage.setItem(STORAGE_THEME_KEY, isDark);
HTML.setAttribute(HTML_THEME_DATASET_KEY, isDark ? "dark" : "light");
};
const initTheme = () => {
const isDark = getJsonFromStorage(STORAGE_THEME_KEY);
if (isDark !== null) updateTheme(isDark);
};
const toggleTheme = () => {
const isDark = getJsonFromStorage(STORAGE_THEME_KEY);
updateTheme(!isDark);
};
document.addEventListener("DOMContentLoaded", () => {
const themeButton = document.getElementById(TOGGLE_BUTTON_ID);
themeButton.addEventListener("click", () => {
toggleTheme();
});
});
initTheme();
2 changes: 1 addition & 1 deletion airflow/www/templates/airflow/main.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
{% endblock %}

{% block head_meta %}
<script src="/static/js/toggle_theme.js"></script>
{{ super() }}
{% if scheduler_job is defined and (scheduler_job and scheduler_job.is_alive()) %}
<meta name="is_scheduler_running" content="True">
Expand Down Expand Up @@ -114,7 +115,6 @@

{% block tail_js %}
{{ super() }}

<script>
// below variables are used in main.js
// keep as var, changing to const or let breaks other code
Expand Down
10 changes: 10 additions & 0 deletions airflow/www/templates/appbuilder/navbar.html
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@
{% include 'appbuilder/navbar_menu.html' %}
</ul>
<ul class="nav navbar-nav navbar-right">
<li class="active">
<div title="Experimental Dark Mode" aria-label="Experimental Dark Mode" style="padding: 20px; cursor: pointer" id="themeToggleButton">
<div id="dark_icon">
<i class="fa-regular fa-moon fa-lg" id="themeToggleButton"></i>
</div>
<div id="light_icon">
<i class="fa-regular fa-sun fa-lg" id="themeToggleButton"></i>
</div>
</div>
</li>
{% include 'appbuilder/navbar_right.html' %}
</ul>
</div>
Expand Down