Update trigger kwargs migration to specify existing_nullable #39361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the existing_nullable set during alter_column, MySQL will set it to Null. See https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.alter_column.params.existing_nullable
boring-cyborg
bot
added
area:db-migrations
Taragolis
approved these changes
May 2, 2024
eladkal
approved these changes
May 2, 2024
ephraimbuddy
added a commit
that referenced
this pull request
May 2, 2024
Without the existing_nullable set during alter_column, MySQL will set it to Null. See https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.alter_column.params.existing_nullable (cherry picked from commit 1d504ca)
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
May 2, 2024
I missed this in the earlier PR on adding the existing_nullable(apache#39361)
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
May 2, 2024
I missed this in the earlier PR on adding the existing_nullable(apache#39361)
ephraimbuddy
added a commit
that referenced
this pull request
May 2, 2024
) I missed this in the earlier PR on adding the existing_nullable(#39361)
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…39361) Without the existing_nullable set during alter_column, MySQL will set it to Null. See https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.alter_column.params.existing_nullable
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
…che#39374) I missed this in the earlier PR on adding the existing_nullable(apache#39361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the existing_nullable set during alter_column, MySQL will set it to Null.
See https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.alter_column.params.existing_nullable