Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the pinecone system test #39365

Merged
merged 6 commits into from
May 6, 2024
Merged

Fix the pinecone system test #39365

merged 6 commits into from
May 6, 2024

Commits on May 6, 2024

  1. Fix the pinecone system test and add default value for metric

    @sunank200
    sunank200 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a18255a View commit details
    Browse the repository at this point in the history

  2. Remove None from metric type

    @sunank200
    sunank200 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9db57e4 View commit details
    Browse the repository at this point in the history

  3. Make default to None

    @sunank200
    sunank200 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bb6bd2b View commit details
    Browse the repository at this point in the history

  4. Fix the PR comments

    @sunank200
    sunank200 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a3c450a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review

    @pankajkoti @sunank200
    pankajkoti authored and sunank200 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7ca6917 View commit details
    Browse the repository at this point in the history

  6. Add sleep time

    @sunank200
    sunank200 committed May 6, 2024
    Configuration menu
    Copy the full SHA
    61c1d92 View commit details
    Browse the repository at this point in the history