openlineage: notify that logged exception was caught #39493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
JDarDagran
approved these changes
May 8, 2024
kaxil
approved these changes
May 8, 2024
RodrigoGanancia
pushed a commit
to RodrigoGanancia/airflow
that referenced
this pull request
May 10, 2024
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of OL listener we catch any exceptions generated by OL implementation: most important feature of OL integration should be to not impact user code. However, we log any potential exceptions.
There's a common issue of people looking at some errors, for example overloaded or buggy OL backend 502ing, which causes the exception stack trace to be written, and assuming it impacts their jobs.
This PR adds warning explaining it's not the case.