Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve DbtCloudJobRunAsyncSensor deprecation in system tests #39525

Merged

Conversation

josh-fell
Copy link
Contributor

Related: #39485

The DbtCloudJobRunAsyncSensor is deprecated in favor of using DbtCloudJobRunSensor with deferrable=True set. Removing this sensor from the dbt Cloud system test and updating documentation accordingly.

Related: apache#39485

The DbtCloudJobRunAsyncSensor is deprecated in favor of using DbtCloudJobRunSensor with `deferrable=True` set. Removing this sensor from the dbt Cloud system test and updating documentation accordingly.
@josh-fell josh-fell added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label May 9, 2024
@josh-fell josh-fell requested a review from Taragolis May 9, 2024 14:39
@Taragolis
Copy link
Contributor

Nice!

Could you also remove this line

"tests/system/providers/dbt/cloud/example_dbt_cloud.py",

@josh-fell
Copy link
Contributor Author

Nice!

Could you also remove this line

"tests/system/providers/dbt/cloud/example_dbt_cloud.py",

Ah yes. Will do!

@josh-fell
Copy link
Contributor Author

Removed in the system test from the ignore list in 5055840

@josh-fell josh-fell merged commit 6455f7f into apache:main May 9, 2024
40 checks passed
@josh-fell josh-fell deleted the handle-dbtcloudjobrunasyncsensor-system-test branch May 9, 2024 15:36
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
…#39525)

* Resolve DbtCloudJobRunAsyncSensor deprecation in system tests

Related: apache#39485

The DbtCloudJobRunAsyncSensor is deprecated in favor of using DbtCloudJobRunSensor with `deferrable=True` set. Removing this sensor from the dbt Cloud system test and updating documentation accordingly.

* Remove dbt Cloud system test from deprecation ignores
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
…#39525)

* Resolve DbtCloudJobRunAsyncSensor deprecation in system tests

Related: apache#39485

The DbtCloudJobRunAsyncSensor is deprecated in favor of using DbtCloudJobRunSensor with `deferrable=True` set. Removing this sensor from the dbt Cloud system test and updating documentation accordingly.

* Remove dbt Cloud system test from deprecation ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers area:system-tests changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation provider:dbt-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants