Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update tracking-user-activity.rst #39611

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

AndrewRocky
Copy link
Contributor

Minor changes:

  • add Matomo to overview
  • make it easier to understand that analytics_url is required only for Matomo (and that Edit airflow.cfg... line is referring to all tools, and not only Matomo)

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Minor changes: 
* add Matomo to overview
* make it easier to understand that `analytics_url` is required only for Matomo (and that `Edit airflow.cfg...` line is referring to all tools, and not only Matomo)
Copy link

boring-cyborg bot commented May 14, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 2.9.2 milestone May 14, 2024
@eladkal eladkal added the type:doc-only Changelog: Doc Only label May 14, 2024
@uranusjr uranusjr merged commit 671d1e8 into apache:main May 14, 2024
38 checks passed
Copy link

boring-cyborg bot commented May 14, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

RNHTTR pushed a commit to RNHTTR/airflow that referenced this pull request Jun 1, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 4, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
utkarsharma2 pushed a commit that referenced this pull request Jun 5, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants