Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbAPiHook executemany parameter of insert_rows should not be deprecated #39630

Conversation

dabla
Copy link
Contributor

@dabla dabla commented May 15, 2024

In a previous PR I deprecated the insertmany parameter of the insert_rows method in the DbAPiHook, but that should not be the case as we have to keep to possibility to let the user choose if he want's to apply a system-wide executemany through the SQL hook using the supports_executemany parameter on the hook class or do it individually where needed, as in some cases you want to use it but in other ones not as the for some databases the amount of data able to be sent by executemany is limitted and then you don't want to use it.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…ecated as for some hooks we don't want to enable a system-wide supports_executemany parameter, that way we can also keep using it in dedicated situations
@potiuk potiuk merged commit 9669f51 into apache:main May 15, 2024
40 checks passed
@dabla
Copy link
Contributor Author

dabla commented May 15, 2024

Thank you guys for approving and merging this PR so quickly :)

@potiuk
Copy link
Member

potiuk commented May 15, 2024

Thank you guys for approving and merging this PR so quickly :)

As I told you :) small PRs can get reviewed and merged quickly. Bigger ones take much more time , and generally review time is not even proportional to size of it but more close to O(n^2) (when we are speaking of non-generated code changes.

RNHTTR pushed a commit to RNHTTR/airflow that referenced this pull request Jun 1, 2024
…ecated as for some hooks we don't want to enable a system-wide supports_executemany parameter, that way we can also keep using it in dedicated situations (apache#39630)

Co-authored-by: David Blain <david.blain@infrabel.be>
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…ecated as for some hooks we don't want to enable a system-wide supports_executemany parameter, that way we can also keep using it in dedicated situations (apache#39630)

Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants