Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SKIP LOCKED instead of NOWAIT in mini scheduler #39745

Merged

Conversation

VladimirYushkevich
Copy link
Contributor

Related: #39680
In this changed argument from nowait to skip_locked for dag_run query. This allows to not rise DB error.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented May 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Taragolis Taragolis added the full tests needed We need to run full set of tests for this PR to merge label May 22, 2024
@Taragolis Taragolis force-pushed the 39680-fix-error-for-obtaining-db-lock branch from 50163bb to b327496 Compare May 22, 2024 15:01
@Taragolis Taragolis added this to the Airflow 2.9.2 milestone May 23, 2024
@Taragolis Taragolis changed the title Change argument for dag_run query. Use SKIP LOCKED instead of NOWAIT in mini scheduler May 23, 2024
@Taragolis Taragolis added the type:bug-fix Changelog: Bug Fixes label May 23, 2024
@dstandish
Copy link
Contributor

Related: #39680 In this changed argument from nowait to skip_locked for dag_run query. This allows to not rise DB error.

Hi can you please share error you are getting and repro steps?

Is it an uncaught error or just a logged exception?

thanks

@Taragolis
Copy link
Contributor

@dstandish
Copy link
Contributor

I know but it should be caught

@VladimirYushkevich
Copy link
Contributor Author

I know but it should be caught

But the problem is this error produces unnecessary noise(with ERROR severity) in Postgres DB. That creates alerts, notifications, etc...

@dstandish
Copy link
Contributor

I know but it should be caught

But the problem is this error produces unnecessary noise(with ERROR severity) in Postgres DB. That creates alerts, notifications, etc...

I see, sure, makes sense

@potiuk
Copy link
Member

potiuk commented May 26, 2024

Looks good @dstandish - are you good with it ? Avoiding server-side error is worth it.

@uranusjr uranusjr merged commit 7dc2b52 into apache:main May 28, 2024
80 of 82 checks passed
Copy link

boring-cyborg bot commented May 28, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@VladimirYushkevich VladimirYushkevich deleted the 39680-fix-error-for-obtaining-db-lock branch May 28, 2024 13:26
RNHTTR pushed a commit to RNHTTR/airflow that referenced this pull request Jun 1, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 4, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
utkarsharma2 pushed a commit that referenced this pull request Jun 5, 2024
ephraimbuddy pushed a commit that referenced this pull request Jun 5, 2024
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants