-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SKIP LOCKED instead of NOWAIT in mini scheduler #39745
Use SKIP LOCKED instead of NOWAIT in mini scheduler #39745
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
50163bb
to
b327496
Compare
Hi can you please share error you are getting and repro steps? Is it an uncaught error or just a logged exception? thanks |
@dstandish this error happen on DB backend, e.g Postgres: |
I know but it should be caught |
But the problem is this error produces unnecessary noise(with ERROR severity) in Postgres DB. That creates alerts, notifications, etc... |
I see, sure, makes sense |
Looks good @dstandish - are you good with it ? Avoiding server-side error is worth it. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
(cherry picked from commit 7dc2b52)
(cherry picked from commit 7dc2b52)
(cherry picked from commit 7dc2b52)
(cherry picked from commit 7dc2b52)
(cherry picked from commit 7dc2b52)
Related: #39680
In this changed argument from
nowait
toskip_locked
for dag_run query. This allows to not rise DB error.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.