Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add comment about remove unused code #39748

Merged
merged 3 commits into from
May 22, 2024
Merged

misc: add comment about remove unused code #39748

merged 3 commits into from
May 22, 2024

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented May 22, 2024

#39212 is planned for 2.9.2 so adding a note when we need to remove the unused code.

Copy link
Member

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in other places that we add a TODO marker for code that needs to be removed later. Might help to also search for these with the TODO marker.

airflow/providers/amazon/aws/executors/ecs/ecs_executor.py Outdated Show resolved Hide resolved
airflow/providers/celery/executors/celery_executor.py Outdated Show resolved Hide resolved
eladkal and others added 2 commits May 22, 2024 13:07
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
@eladkal eladkal merged commit 7b588b4 into apache:main May 22, 2024
41 checks passed
@eladkal eladkal deleted the ecs branch May 22, 2024 11:04
RNHTTR pushed a commit to RNHTTR/airflow that referenced this pull request Jun 1, 2024
* misc: add comment about remove unused code

* Update airflow/providers/amazon/aws/executors/ecs/ecs_executor.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

* Update airflow/providers/celery/executors/celery_executor.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* misc: add comment about remove unused code

* Update airflow/providers/amazon/aws/executors/ecs/ecs_executor.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

* Update airflow/providers/celery/executors/celery_executor.py

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>

---------

Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants