-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh properties on KubernetesPodOperator on token expiration also when logging #39789
Merged
pankajastro
merged 3 commits into
apache:main
from
paolo-moriello:k8spodoperator-refresh-token-logs
May 30, 2024
Merged
Refresh properties on KubernetesPodOperator on token expiration also when logging #39789
pankajastro
merged 3 commits into
apache:main
from
paolo-moriello:k8spodoperator-refresh-token-logs
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
reviewed
May 24, 2024
02b3b51
to
d7852f6
Compare
d7852f6
to
1f1324b
Compare
… when logs are enabled
1f1324b
to
a825540
Compare
@amoghrajesh could you please have another look? |
hey, this is a bug in the |
Lee-W
approved these changes
May 30, 2024
pankajastro
approved these changes
May 30, 2024
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…when logging (apache#39789) * Refresh KubernetesPodOperator properties when credentials expire also when logs are enabled * Linting * Rename function --------- Co-authored-by: pmoriello <paolo.moriello@zalando.ch>
27 tasks
jannisko
pushed a commit
to jannisko/airflow
that referenced
this pull request
Jun 15, 2024
…when logging (apache#39789) * Refresh KubernetesPodOperator properties when credentials expire also when logs are enabled * Linting * Rename function --------- Co-authored-by: pmoriello <paolo.moriello@zalando.ch>
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…when logging (apache#39789) * Refresh KubernetesPodOperator properties when credentials expire also when logs are enabled * Linting * Rename function --------- Co-authored-by: pmoriello <paolo.moriello@zalando.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on this pr: #39325.
The above PR addressed an issue for which
KubernetesPodOperator
properties were refreshed on auth-token expiration.This PR covers also the
get_logs=True
case, which was not covered by the previous change, aiming at fixing this exception:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.