Remove DAG Run Add option from FAB view #39881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
vincbeck
approved these changes
May 27, 2024
RNHTTR
pushed a commit
to RNHTTR/airflow
that referenced
this pull request
Jun 1, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 4, 2024
(cherry picked from commit 54b4d76)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 54b4d76)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 54b4d76)
utkarsharma2
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 54b4d76)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 54b4d76)
41 tasks
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know from which time onwards it was possible to create a new DAG run from FAB UI but as reported in #39856 this is broken at least since notes can be added.
In my perspective I have never seen this option and can not imagine it is working anyway, therefore I propose the
/dagrun/addto be removed. If a DAG should be triggered it should use the "play" button and run through the UI/API to trigger a new run.closes: #39856