Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): allow valueFrom in env config of components (#40095) #40135

Conversation

dada-engineer
Copy link
Contributor

@dada-engineer dada-engineer commented Jun 8, 2024

This fixes #40095 and allows the users of the official helm chart to add a valueFrom specification (for secret and configmap references) to the env config of components (most of them use the container_extra_env functions defined in _helpers.yaml).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jun 8, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Jun 8, 2024

Could you please add a unit test for it (helm_tests dir)

@dada-engineer
Copy link
Contributor Author

Oh sure sorry totally missed that one 🙈

@eladkal eladkal requested a review from romsharon98 June 8, 2024 11:10
@dada-engineer dada-engineer force-pushed the 40095-chart-custom-env-with-value-from-for-cleanup-job branch from 1666c0d to 2055bb4 Compare June 10, 2024 09:17
@dada-engineer
Copy link
Contributor Author

Could you please add a unit test for it (helm_tests dir)

done

You also need to do apply it here.

done

thanks @potiuk and @jedcunningham and sorry for the delay

@jedcunningham jedcunningham merged commit 279e8b7 into apache:main Jun 11, 2024
62 checks passed
Copy link

boring-cyborg bot commented Jun 11, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

Thanks @dada-engineer! Congrats on your first commit 🎉

jannisko pushed a commit to jannisko/airflow that referenced this pull request Jun 15, 2024
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart: Allow to extend cleanup cronjob env with custom envs from secrets or config maps
5 participants