Chart: set workers.safeToEvict default to False
#40229
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a safer default for our workers. This can be safe to set to true if you have a long enough `workers.terminationGracePeriodSeconds` set, but what is "long enough" is very situational, so I feel its better to default to not evicting worker pods.
eladkal
approved these changes
Jun 14, 2024
ephraimbuddy
approved these changes
Jun 14, 2024
|
There isn't a binary default. The short version is CA considers pods safe to evict unless the annotation is set to False, or the pod isn't backed by a controller object (e.g. deployment/statefulset). For Airflow, this means that the CE workers would be considered evictable and KE workers would not, by default, without the annotation. There are other conditions as well, which you can read about in the CA FAQ. |
13 tasks
jannisko
pushed a commit
to jannisko/airflow
that referenced
this pull request
Jun 15, 2024
This is a safer default for our workers. This can be safe to set to true if you have a long enough `workers.terminationGracePeriodSeconds` set, but what is "long enough" is very situational, so I feel its better to default to not evicting worker pods.
utkarsharma2
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a safer default for our workers.
This can be safe to set to true if you have a long enough
workers.terminationGracePeriodSecondsset, but what is "long enough" is very situational, so I feel its better to default to not evicting worker pods.