extra being passed to SQLalchemy #40391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritra24
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
|
Not entirely sure if this is the place to do the fix, or perhaps while creating the url we check for empty extra here? I guess it would be better to not prefill an empty dict? |
uranusjr
reviewed
Jun 24, 2024
uranusjr
reviewed
Jun 24, 2024
The edit prefills an empty extra field (None) with a empty dictionary, which is decoded to an extra field being passed in the con url.
|
@uranusjr could you please merge this. I don't have merge rights :p |
eladkal
approved these changes
Jun 27, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 2, 2024
The edit prefills an empty extra field (None) with a empty dictionary, which is decoded to an extra field being passed in the con url. (cherry picked from commit a856ed4)
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 2, 2024
The edit prefills an empty extra field (None) with a empty dictionary, which is decoded to an extra field being passed in the con url. (cherry picked from commit a856ed4)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 2, 2024
The edit prefills an empty extra field (None) with a empty dictionary, which is decoded to an extra field being passed in the con url. (cherry picked from commit a856ed4)
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit prefills an empty extra field (None)
with a empty dictionary, which is decoded
to an extra field being passed in the con url.
Fixes: #40056
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.