Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix :RedshiftDataOperator fails when return_sql_result is true #40443

Closed
wants to merge 8 commits into from

Conversation

isatyamks
Copy link


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jun 26, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@isatyamks isatyamks changed the title changes in https://github.com/apache/airflow/blob/providers-amazon/8.24.0/airflow/providers/amazon/aws/operators/redshift_data.py#L186 fix :RedshiftDataOperator fails when return_sql_result is true Jun 26, 2024
@isatyamks isatyamks closed this Jun 27, 2024
@isatyamks
Copy link
Author

airflow/providers/amazon/aws/operators/redshift_data.py----->

Ensure self.sql is a list

if isinstance(self.sql, str):
    self.sql = [self.sql]

@isatyamks isatyamks reopened this Jun 27, 2024
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests should also be updated and/or added

airflow/providers/amazon/aws/operators/redshift_data.py Outdated Show resolved Hide resolved
@isatyamks
Copy link
Author

@vincbeck, @o-nikolas ,@eladkal please review the changes and proceed with the merge if the changes are accurate and appropriate.

@vincbeck
Copy link
Contributor

vincbeck commented Jul 2, 2024

@vincbeck, @o-nikolas ,@eladkal please review the changes and proceed with the merge if the changes are accurate and appropriate.

Tests are failing, please fix them

@isatyamks
Copy link
Author

@vincbeck can you please help me to fix it

@vincbeck
Copy link
Contributor

vincbeck commented Jul 2, 2024

@vincbeck can you please help me to fix it

Please look at the logs failure below. There are many. One example: https://github.com/apache/airflow/actions/runs/9765159007/job/26957199944?pr=40443

Have you run pre-commits? It seems you have not. A good start is to read the contributor quick start if you have not. https://github.com/apache/airflow/blob/main/contributing-docs/03_contributors_quick_start.rst

Other docs are definitely worth readable to fix your issues:

@isatyamks
Copy link
Author

isatyamks commented Jul 7, 2024

@vincbeck its fixed!

@isatyamks isatyamks closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants