-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix :RedshiftDataOperator fails when return_sql_result is true #40443
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
airflow/providers/amazon/aws/operators/redshift_data.py-----> Ensure self.sql is a list
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests should also be updated and/or added
@vincbeck, @o-nikolas ,@eladkal please review the changes and proceed with the merge if the changes are accurate and appropriate. |
Tests are failing, please fix them |
@vincbeck can you please help me to fix it |
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
1360a28
to
b869951
Compare
Please look at the logs failure below. There are many. One example: https://github.com/apache/airflow/actions/runs/9765159007/job/26957199944?pr=40443 Have you run pre-commits? It seems you have not. A good start is to read the contributor quick start if you have not. https://github.com/apache/airflow/blob/main/contributing-docs/03_contributors_quick_start.rst Other docs are definitely worth readable to fix your issues:
|
@vincbeck its fixed! |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.