[AIRFLOW-3353] Upgrade redis client.

[jmcarp]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-3353
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Upgrade redis client to latest and rename StrictRedis to Redis.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Covered by existing tests.

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

• Passes flake8

[codecov-io]

Codecov Report

Merging #4203 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4203      +/-   ##
=========================================
+ Coverage    77.7%   77.7%   +<.01%     
=========================================
  Files         199     199              
  Lines       16315   16315              
=========================================
+ Hits        12677   12678       +1     
+ Misses       3638    3637       -1

Impacted Files	Coverage Δ
airflow/configuration.py	89.05% <0%> (+0.36%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fac6b9...465b91e. Read the comment docs.

[ashb]

I need to revert this - right now this version of Redis breaks Celery.

[ashb]

Once celery/kombu#948 or something like that is fixed in combo we can bring this change back

[r39132]

@ashb Sorry for this.. it looked like a good change and tests were passing. Our tests didn't catch this?

[jmcarp]

Sorry! I had the same question about tests. Would it be worthwhile to add an integration test to make sure the celery executor works?

[ashb]

Yup, it's the fix for our hook.

Reduced integration tests (i.e. not the full suite, just a few dag tests like we do for kube) hitting celery+redis would be amazing to add!