[AIRFLOW-3554] Remove contrib folder from code cov omit list

[feluelle]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-3554
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Currently the contrib folder is not being processed by codecov.
That means that contributors won't see a code coverage of their implemented code in this folder.
To generally improve code/test coverage for this project I would recommend to enable coverage for the contrib folder, too.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
  • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

• Passes flake8

[codecov-io]

Codecov Report

Merging #4351 into master will increase coverage by 57.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #4351       +/-   ##
==========================================
+ Coverage   16.13%   73.7%   +57.57%     
==========================================
  Files         202     411      +209     
  Lines       16483   28786    +12303     
==========================================
+ Hits         2660   21218    +18558     
+ Misses      13823    7568     -6255

Impacted Files	Coverage Δ
...ow/contrib/example_dags/example_qubole_operator.py	0% <0%> (ø)
airflow/contrib/operators/s3_list_operator.py	100% <0%> (ø)
...low/contrib/operators/wasb_delete_blob_operator.py	100% <0%> (ø)
airflow/contrib/hooks/vertica_hook.py	50% <0%> (ø)
...flow/contrib/example_dags/example_qubole_sensor.py	0% <0%> (ø)
airflow/contrib/sensors/pubsub_sensor.py	100% <0%> (ø)
airflow/contrib/hooks/qubole_hook.py	53.65% <0%> (ø)
airflow/contrib/hooks/databricks_hook.py	95.61% <0%> (ø)
airflow/contrib/hooks/aws_firehose_hook.py	100% <0%> (ø)
airflow/contrib/sensors/wasb_sensor.py	100% <0%> (ø)
... and 370 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f211390...cc6a49a. Read the comment docs.

[feluelle]

@kaxil @Fokko What do you guys think of this?

[kaxil]

+1 from my side, we are anyway maintaining the entire codebase. But want to hear thought from other committers as well @jlowin @feng-tao @Fokko @ashb ?

[Fokko]

I'm okay with this as well. The contrib code should have tests as well.

[ashb]

💯