Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3582] Adds tests for HiveStatsCollectionOperator #4398

Merged

Conversation

feluelle
Copy link
Member

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

  • adds tests for hive_stats_operator

  • removes duplicated entry in list used in get_default_exprs

  • refactoring

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

- adds tests for hive_stats_operator
- removes duplicated entry in list used in get_default_exprs
- refactoring
@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #4398 into master will increase coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4398      +/-   ##
==========================================
+ Coverage   78.17%   78.63%   +0.45%     
==========================================
  Files         204      204              
  Lines       16529    16529              
==========================================
+ Hits        12921    12997      +76     
+ Misses       3608     3532      -76
Impacted Files Coverage Δ
airflow/operators/hive_stats_operator.py 100% <100%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65843a6...a5d3eb1. Read the comment docs.

@kaxil kaxil merged commit 59eb9cf into apache:master Jan 9, 2019
@kaxil
Copy link
Member

kaxil commented Jan 9, 2019

Thanks @feluelle

@feluelle
Copy link
Member Author

feluelle commented Jan 9, 2019

Thanks to you @kaxil :)

@feluelle feluelle deleted the feature/AIRFLOW-3582-tests-hive-stats-operator branch April 9, 2019 12:09
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants