Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3402] Port PR #4247 to 1.10-test #4454

Merged
merged 1 commit into from Jan 7, 2019

Conversation

kppullin
Copy link
Contributor

@kppullin kppullin commented Jan 7, 2019

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This is a manual port of AIRFLOW-3402 (PR #4247) to the v1-10-test branch, as cherry picking lead to conflicts.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Tests ported from original PR.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • Passes flake8

(note, flake8 tests appear broken in the current HEAD of v1.10-test, but no issues related to this change).

@kppullin
Copy link
Contributor Author

kppullin commented Jan 7, 2019

@kaxil - Per your request in #4247, I've done a manual merge to the v1-10-test branch.

As noted above, the CI test run is currently failed due to an unrelated, existing issue with the flake8 tests. All other tests are passing on the CI runs from my fork (https://travis-ci.org/kppullin/airflow/builds/476172231).

@kaxil kaxil force-pushed the v1-10-test branch 2 times, most recently from dc89b00 to cb5db9c Compare January 7, 2019 20:38
@kaxil kaxil merged commit 5115307 into apache:v1-10-test Jan 7, 2019
@kppullin kppullin deleted the 3402-cherry-pick-1.10-test branch January 7, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants