Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3730] Standarization use of logs mechanisms #4556

Merged
merged 1 commit into from Jan 31, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jan 18, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

Some operators did not use the logging mechanism from Airflow, but used the Python mechanism.
Some operators extend the 'LoggingMixin' class when it is not needed.
This change standardizes these changes.

Tests

I'm not introducing new changes. Only rewrites the code.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@codecov-io
Copy link

Codecov Report

Merging #4556 into master will increase coverage by 1.68%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4556      +/-   ##
==========================================
+ Coverage   74.16%   75.85%   +1.68%     
==========================================
  Files         421      425       +4     
  Lines       27773    31940    +4167     
==========================================
+ Hits        20598    24227    +3629     
- Misses       7175     7713     +538
Impacted Files Coverage Δ
airflow/contrib/hooks/winrm_hook.py 0% <0%> (ø) ⬆️
airflow/contrib/hooks/salesforce_hook.py 0% <0%> (ø) ⬆️
airflow/contrib/hooks/ftp_hook.py 70.55% <100%> (+10.19%) ⬆️
airflow/contrib/hooks/ssh_hook.py 87.36% <100%> (-0.14%) ⬇️
airflow/contrib/hooks/segment_hook.py 69.23% <100%> (-1.14%) ⬇️
airflow/contrib/sensors/sftp_sensor.py 100% <100%> (ø) ⬆️
airflow/contrib/hooks/redis_hook.py 100% <100%> (ø) ⬆️
airflow/contrib/hooks/jira_hook.py 82.85% <100%> (-0.48%) ⬇️
airflow/contrib/hooks/sqoop_hook.py 95.33% <100%> (-0.04%) ⬇️
airflow/contrib/hooks/databricks_hook.py 95.57% <100%> (-0.04%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed71a7...216e8f0. Read the comment docs.

@ashb ashb merged commit d126d9e into apache:master Jan 31, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Mar 27, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants