[AIRFLOW-XXX] Fix spark submit hook KeyError

[zhongjiajie]

Fix string format KeyError in
spark_submit_hook.py

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-XXX
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR does not need testing for this extremely good reason: tiny change

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
  • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

• Passes flake8

[zhongjiajie]

@ash @feng @kaxil PTAL, thx.

[codecov-io]

Codecov Report

Merging #4578 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4578      +/-   ##
==========================================
+ Coverage   74.13%   74.14%   +<.01%     
==========================================
  Files         421      421              
  Lines       27724    27724              
==========================================
+ Hits        20554    20555       +1     
+ Misses       7170     7169       -1

Impacted Files	Coverage Δ
airflow/contrib/hooks/spark_submit_hook.py	79.82% <ø> (ø)	⬆️
airflow/models/__init__.py	92.5% <0%> (+0.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b53e2...ec03aa5. Read the comment docs.

[feng-tao]

Should this have a jira ticket? Otherwise it won't get included in the next release.

[zhongjiajie]

@feng-tao Do you mean I should create a issue in jira to report that?

[ashb]

It's a bit late to create the Jira ticket now, but I probably shouldn't have merged this without one. My bad.

[zhongjiajie]

I think is minor changes so don't create the Jira ticket, just like #4552 (comment) suggest.

So if I modify code, I have to create Jira ticket, rigth?

[ashb]

The difference is 4552 was a doc change (that was in a .py file) - this is a code change.

[zhongjiajie]

Ok, I get it, I sorry to do that