Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3868] - Incorrect import of distutils in JenkinsHook #4689

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-3868] - Incorrect import of distutils in JenkinsHook #4689

wants to merge 1 commit into from

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Feb 11, 2019

Make sure you have checked all steps below.

Jira

Description

Fix error AttributeError: module 'distutils' has no attribute 'util'

Before:

Python 3.6.7
>>> import distutils
>>> print (distutils.util.strtobool('true'))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'distutils' has no attribute 'util'
>>>

After:

Python 3.6.7
>>> from distutils.util import strtobool
>>> print (strtobool('true'))
1

Code Quality

  • [V] Passes flake8

Fix error AttributeError: module 'distutils' has no attribute 'util'
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #4689 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4689   +/-   ##
=======================================
  Coverage   74.35%   74.35%           
=======================================
  Files         430      430           
  Lines       27962    27962           
=======================================
  Hits        20791    20791           
  Misses       7171     7171
Impacted Files Coverage Δ
airflow/contrib/hooks/jenkins_hook.py 35.29% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3041f2f...9fa7e07. Read the comment docs.

@eladkal
Copy link
Contributor Author

eladkal commented Feb 12, 2019

This no longer needed as #4397 was merged.

@eladkal eladkal closed this Feb 12, 2019
@Fokko
Copy link
Contributor

Fokko commented Feb 12, 2019

I'm sorry @eladkal I was going from old to new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants