Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Pin pinodb dependency to fix the existing issue #4704

Merged
merged 1 commit into from Feb 13, 2019

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Feb 13, 2019

pinodb 0.2.2 has a breaking change which breaks the unit test. Pin the dependency for now.

47) ERROR: Failure: SyntaxError (invalid syntax (db.py, line 41))
----------------------------------------------------------------------
   Traceback (most recent call last):
    .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/nose/loader.py line 418 in loadTestsFromName
      addr.filename, addr.module)
    .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/nose/importer.py line 47 in importFromPath
      return self.importFromDir(dir_path, fqname)
    .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/nose/importer.py line 94 in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    tests/contrib/hooks/test_pinot_hook.py line 24 in <module>
      from airflow.contrib.hooks.pinot_hook import PinotDbApiHook
    airflow/contrib/hooks/pinot_hook.py line 22 in <module>
      from pinotdb import connect
    .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/pinotdb/__init__.py line 1 in <module>
      from pinotdb.db import connect
   SyntaxError: invalid syntax (db.py, line 41)```

@feng-tao
Copy link
Member Author

PTAL @ashb @ffinfo

@feng-tao
Copy link
Member Author

And @kaxil @Fokko

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #4704 into master will increase coverage by 63.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #4704       +/-   ##
==========================================
+ Coverage   11.03%   74.4%   +63.37%     
==========================================
  Files         430     430               
  Lines       27971   27971               
==========================================
+ Hits         3087   20813    +17726     
+ Misses      24884    7158    -17726
Impacted Files Coverage Δ
airflow/plugins_manager.py 86.66% <0%> (+0.95%) ⬆️
airflow/executors/dask_executor.py 2% <0%> (+2%) ⬆️
airflow/exceptions.py 100% <0%> (+2.85%) ⬆️
airflow/utils/operator_resources.py 86.95% <0%> (+4.34%) ⬆️
...etes_request_factory/kubernetes_request_factory.py 72.82% <0%> (+5.43%) ⬆️
airflow/executors/__init__.py 63.46% <0%> (+5.76%) ⬆️
airflow/utils/module_loading.py 100% <0%> (+10.52%) ⬆️
airflow/settings.py 80.88% <0%> (+13.23%) ⬆️
airflow/utils/decorators.py 91.66% <0%> (+14.58%) ⬆️
airflow/hooks/oracle_hook.py 15.47% <0%> (+15.47%) ⬆️
... and 329 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10df79e...1479e40. Read the comment docs.

@ashb ashb merged commit 2db8b40 into apache:master Feb 13, 2019
ashb pushed a commit that referenced this pull request Feb 13, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants