-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4358] Speed up test_jobs by not running tasks #5162
Conversation
Nice! It is always good to speed up the CI! |
|
e1e560c
to
e6fb983
Compare
Imprecise numbers on tests - it looks like this saves 4mins on Sqlite tests, and ~10mins on mysql/postgres (where we run backfill!) Before (master build): TOX_ENV=py35-backend_mysql-env_docker 34 min 24 sec After: TOX_ENV=py35-backend_mysql-env_docker 24 min 51 sec |
Codecov Report
@@ Coverage Diff @@
## master #5162 +/- ##
==========================================
- Coverage 78.56% 78.56% -0.01%
==========================================
Files 469 469
Lines 29912 29912
==========================================
- Hits 23501 23500 -1
- Misses 6411 6412 +1
Continue to review full report at Codecov.
|
LGTM |
@ashb -> i will have more time on weekend to take a look. But at first glance it looks good. |
e6fb983
to
e01b9ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ashb
I only found one thing I think can be improved here..
f9d7a5c
to
af613ea
Compare
ba2885c
to
8774cee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot!
We don't care about the behaviour of the tasks in most cases (as we test those elsewhere) - we just care that the task is "run" and ends in a state, which we can all do more directly. On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds!
8774cee
to
902fc34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. :-)
We don't care about the behaviour of the tasks in most cases (as we test those elsewhere) - we just care that the task is "run" and ends in a state, which we can all do more directly. On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds! (cherry picked from commit b69c686)
We don't care about the behaviour of the tasks in most cases (as we test those elsewhere) - we just care that the task is "run" and ends in a state, which we can all do more directly. On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds! (cherry picked from commit b69c686)
We don't care about the behaviour of the tasks in most cases (as we test those elsewhere) - we just care that the task is "run" and ends in a state, which we can all do more directly. On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds!
We don't care about the behaviour of the tasks in most cases (as we test those elsewhere) - we just care that the task is "run" and ends in a state, which we can all do more directly. On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds!
We don't care about the behaviour of the tasks in most cases (as we test those elsewhere) - we just care that the task is "run" and ends in a state, which we can all do more directly. On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds! (cherry picked from commit b69c686)
Make sure you have checked all steps below.
Jira
Description
We don't care about the behaviour of the tasks (we test those elsewhere) - we just care that the task is "run" and yeilds a state, which we can all do more directly.
On my laptop this takes the time for SchedulerJobTest from 133s to 35s, and reduces the BackfillJobTests from >5mins to mere seconds!
I think this approach still tests the behaviour well enough
Tests
Commits
Documentation
Code Quality
flake8