Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Airlfow-XXXX] Add docs for Google Cloud Storage Sensors #5201

Closed
wants to merge 8 commits into from
Closed

[Airlfow-XXXX] Add docs for Google Cloud Storage Sensors #5201

wants to merge 8 commits into from

Conversation

jaketf
Copy link
Contributor

@jaketf jaketf commented Apr 28, 2019

This PR adds documentation for the Google Cloud Storage sensors to integrations.rst

Jacob Ferriero added 6 commits April 24, 2019 00:04
[AIRFLOW-4397] Add GCSUploadSessionCompleteSensor
996033a 
This commit add a GoogleCloudStorageUploadSessionCompleteSensor
to address the use case of accepting files from a third party vendor
who refuses to send a success indicator when providing data files
into a bucket and waiting until an inactivity period has passed to
indicate the end of an upload session.

fix style

fix style
[AIRFLOW-4397] refactor to use system time per review commentsw
6b97f00
[AIRFLOW-4397] clarifying docstring for previous_num_files
700465a
[Airflow-4397] handle object deletes between pokes
5817d28
[AIRFLOW-4397] Fix style for flake8 pass
6b85cd6
add documentation for Google Cloud Storage sensors.
84b45b8
@jaketf
Copy link
Contributor Author

jaketf commented Apr 28, 2019

@potiuk @OmerJog hopefully this addresses the documentation gap in integrations.rst

@codecov-io
Copy link

codecov-io commented Apr 28, 2019 •
edited

Codecov Report

Merging #5201 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5201     +/-   ##
=========================================
+ Coverage   78.46%   78.56%   +0.1%     
=========================================
  Files         469      469             
  Lines       29912    29912             
=========================================
+ Hits        23469    23499     +30     
+ Misses       6443     6413     -30
Impacted Files Coverage Δ
airflow/models/taskinstance.py 92.42% <0%> (-0.18%) ⬇️
airflow/jobs.py 78.49% <0%> (+0.69%) ⬆️
airflow/utils/dag_processing.py 59.47% <0%> (+1.04%) ⬆️
airflow/executors/__init__.py 66.66% <0%> (+4.16%) ⬆️
airflow/utils/sqlalchemy.py 80.95% <0%> (+4.76%) ⬆️
airflow/executors/sequential_executor.py 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69c686...774fd15. Read the comment docs.

@potiuk
Copy link
Member

potiuk commented Apr 29, 2019

Just the last commit is needed since the sensor is already merged. Can you please rebase just the last on on top of master

@jaketf
Copy link
Contributor Author

jaketf commented Apr 30, 2019

Got lost in rebase hell. Will open a new PR to manually rebase.

@jaketf jaketf closed this Apr 30, 2019
@jaketf jaketf mentioned this pull request Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaketf @codecov-io @potiuk