[AIRFLOW-4505] Correct Tag ALL for PY3

[raphaelauv]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-4505] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-4505
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
  • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

• Here are some details about my PR, including screenshots of any UI changes:

A new tag , so we could get ALL PY3 packages ( without PY2 )

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

• Passes flake8

[raphaelauv]

Do I need to base the PR on something else than master ? So the current Pypi on 1.10.3 , work directly when this PR is (I hope) merged

[codecov-io]

Codecov Report

Merging #5275 into v1-10-test will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           v1-10-test    #5275      +/-   ##
==============================================
- Coverage       79.17%   79.16%   -0.01%     
==============================================
  Files             243      243              
  Lines           17806    17806              
==============================================
- Hits            14098    14097       -1     
- Misses           3708     3709       +1

Impacted Files	Coverage Δ
airflow/models/taskinstance.py	92.42% <0%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1064b4...296c546. Read the comment docs.

[potiuk]

I think we should just remove the PY3 check in master. In master we anyhow only support PY3 now. If we would like to change it in 1.10.x series we should branch it from v1-10-test, but I think there installing devel_ci would do the trick and maybe we should not introduce a new tag just for that in the 1.10.x series.

[raphaelauv]

@potiuk Thank you , I just changed the base of the PR to v1-10-test.

Yes devel_ci do the trick , but that's what I was arguing against in the issue of the PR :
https://issues.apache.org/jira/browse/AIRFLOW-4505

It's not very user friendly.

[potiuk]

OK. I looked back at it, and I have second thought.

Would not it be better to simply make devel_all conditional based on PY3 same way devel_ci is done? that would not introduce new tag, and it would magically work if you run it in py3 virtualenv :) @raphaelauv .

[raphaelauv]

@potiuk It could, but for people currently using devel_all with PY2 it would be a regression , is this a risk you want a take ?

[potiuk]

@raphaelauv What regression ? I cannot see any scenario where it could break things ? If you are using py2 it will continue working as it did before. It's just py3 will not install snakebite .

[potiuk]

That's much nicer :)

[aijamalnk]

Should this be merged now that it's approved?