Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4739] Add ability to specify labels per task with kubernetes executor config #5376

Merged
merged 1 commit into from Jun 21, 2019

Conversation

george-miller
Copy link
Contributor

@george-miller george-miller commented Jun 5, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4739
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

I want to be able to add arbitrary labels to an airflow worker pod. For example, I want to specify this in the task definition:

run_this = PythonOperator(
task_id='print_the_context',
provide_context=True,
python_callable=my_sleeping_function,
executor_config={"KubernetesExecutor": {"labels":
  {"test": "label"}
}},
dag=dag,
)

And have my worker pod have the label test:label.

My main use case for this is for auditing. We audit our kubernetes cluster by tags, attributing cost based on how much resources the pod uses.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@george-miller george-miller force-pushed the kubernetes_per_task_labels branch 4 times, most recently from fdd5424 to 671425b Compare June 5, 2019 21:04
…d labels

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`
@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #5376 into master will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
- Coverage   79.02%   79.02%   -0.01%     
==========================================
  Files         481      481              
  Lines       30197    30200       +3     
==========================================
+ Hits        23864    23865       +1     
- Misses       6333     6335       +2
Impacted Files Coverage Δ
...ontrib/example_dags/example_kubernetes_executor.py 0% <0%> (ø) ⬆️
airflow/kubernetes/worker_configuration.py 96.06% <100%> (+0.03%) ⬆️
airflow/executors/kubernetes_executor.py 66.14% <100%> (+0.08%) ⬆️
airflow/models/taskinstance.py 92.43% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e87e89...d2784cf. Read the comment docs.

@pgagnon
Copy link
Contributor

pgagnon commented Jun 10, 2019

@dimberman

@dimberman dimberman merged commit f457b1f into apache:master Jun 21, 2019
ashb pushed a commit that referenced this pull request Jun 23, 2019
…d labels (#5376)

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`

(cherry picked from commit f457b1f)
kaxil pushed a commit that referenced this pull request Jun 24, 2019
…d labels (#5376)

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`

(cherry picked from commit f457b1f)
ashb pushed a commit that referenced this pull request Jun 24, 2019
…d labels (#5376)

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`

(cherry picked from commit f457b1f)
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
…d labels (apache#5376)

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
…d labels (apache#5376)

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
…d labels (apache#5376)

Allow task definitions to specify labels on the worker pods that
execute that task by specifying an extra field in executor_config
like so
`executor_config={"KubernetesExecutor": {"labels": {"foo":"bar"}}}`

(cherry picked from commit f457b1f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants