[AIRFLOW-4961] Set TaskFail.duration as int match DB schema column type #5593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a task failure record, convert 'duration' decimal
value -> an int before persistence, to remove reliance on the
database doing this automatically and gracefully.
Make sure you have checked all steps below.
Jira
Description
I raised https://issues.apache.org/jira/browse/AIRFLOW-4961 earlier today, to cover a minor issue we encountered whilst running airflow using CockroachDB. That ticket covers the full explanation of this PR.
Tests
There aren't currently unit tests for testfail.py (that's not to say there shouldn't be), and an integration test would pass with the present code anyway, as Postgres' error handling masks the issue.
It's also a pretty trivial change. Happy to add a test for testfail.py if we feel it's needed though.
Commits
Documentation
Code Quality
flake8