New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-5003] Making AWS Hooks pylint compatible #5627

Merged

potiuk merged 3 commits into apache:master from ishan4488:master

Aug 7, 2019

Contributor

ishan4488 commented Jul 21, 2019 •

edited

Make sure you have checked all steps below.

Jira

My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

Here are some details about my PR, including screenshots of any UI changes:

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters (not including Jira issue reference)
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Documentation

In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

Passes flake8

mik-laj reviewed

View reviewed changes

airflow/contrib/hooks/aws_dynamodb_hook.py

    
            @@ -17,6 +17,10 @@
          
              # specific language governing permissions and limitations

Member

mik-laj Jul 21, 2019

Is changing the file permissions necessary?

Contributor Author

ishan4488 Jul 22, 2019 •

edited

No. Fixing the file permissions and pushing the code again.

ishan4488 force-pushed the master branch from ad2eb56 to c1afe57 Compare

July 22, 2019 03:12


          [AIRFLOW-5003] Making AWS Hooks pylint compatible

725256f

ishan4488 force-pushed the master branch from c1afe57 to 725256f Compare

July 22, 2019 03:56


          fixup! [AIRFLOW-5003] Making AWS Hooks pylint compatible

b94bcf7

mik-laj force-pushed the master branch from e81240f to b94bcf7 Compare

July 24, 2019 06:16

Member

mik-laj commented Jul 24, 2019 •

edited

I deleted unrelated changes from this PR.

 CONTRIBUTING.md                                       | 1 -
 tests/contrib/operators/test_gcp_transfer_operator.py | 2 +-

mik-laj added the provider:amazon-aws label

mik-laj reviewed

View reviewed changes

airflow/contrib/hooks/gcp_dataproc_hook.py Outdated

		from zope.deprecation import deprecation
		from googleapiclient.discovery import build

Member

mik-laj Aug 6, 2019

It's look like unrelated change.


          fixup! fixup! [AIRFLOW-5003] Making AWS Hooks pylint compatible

63b5030

Member

mik-laj commented Aug 6, 2019

I removed unrelated change.

potiuk merged commit 157170b into apache:master

ashb pushed a commit to ashb/airflow that referenced this pull request


          [AIRFLOW-5003] Making AWS Hooks pylint compatible (apache#5627)

084a751

(cherry picked from commit 157170b)

adityav pushed a commit to adityav/airflow that referenced this pull request


          [AIRFLOW-5003] Making AWS Hooks pylint compatible (apache#5627)

372b5d8

(cherry picked from commit 157170b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment