Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle elasticsearch json_format as a boolean #5754

Closed
wants to merge 1 commit into from

Conversation

lsowen
Copy link

@lsowen lsowen commented Aug 8, 2019

Is a boolean, but is read as a string, which means it is always considered True, even though the default config value is False.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Is a boolean, but is read as a string, which means it is _always_ considered True, even though the default config value is `False`.
@lsowen
Copy link
Author

lsowen commented Aug 8, 2019

Looks like a spurious test failure: Error: Invalid or corrupt jarfile /tmp/apache-rat-0.12.jar

@potiuk
Copy link
Member

potiuk commented Aug 8, 2019

Yeah. Networking issue likely. Restarted

@lsowen
Copy link
Author

lsowen commented Aug 8, 2019

@potiuk thanks for kicking it off again. However, it says that the build has been cancelled?

@mik-laj
Copy link
Member

mik-laj commented Aug 8, 2019

I restarted this build.

@lsowen
Copy link
Author

lsowen commented Aug 13, 2019

Do I need to do anything else to get this merged? Or is it good? (just waiting on flaky test?)

@OmerJog
Copy link
Contributor

OmerJog commented Sep 24, 2019

@lsowen
It's a code change hence you need a Jira ticket, after you open Jira edit commit message with :
[AIRFLOW -$JIRANUMBER] handle elasticsearch json_format as a boolean

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 20, 2019
@stale stale bot closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants