Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-5200] Move GCP PubSub to core #5803

Merged
merged 1 commit into from Aug 17, 2019
Merged

[AIRFLOW-5200] Move GCP PubSub to core #5803

merged 1 commit into from Aug 17, 2019

Conversation

turbaszek
Copy link
Member

@turbaszek turbaszek commented Aug 13, 2019 •
edited

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This commit moves GCP PubSub from contrib to core. For more information check AIP-21.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@turbaszek
Copy link
Member Author

Depends on #5791

@mik-laj mik-laj added AIP-21 provider:google Google (including GCP) related issues labels Aug 13, 2019
@mik-laj
Copy link
Member

mik-laj commented Aug 13, 2019

Pylint is sad :-/

@turbaszek turbaszek force-pushed the gcp-pub-sub branch 3 times, most recently from d722a26 to ada3585 Compare August 16, 2019 21:07
@turbaszek turbaszek changed the title [AIRFLOW-5200][depend on AIRFLOW 5183] Move GCP PubSub to core [AIRFLOW-5200] Move GCP PubSub to core Aug 16, 2019
coufon
coufon approved these changes Aug 17, 2019
View reviewed changes
airflow/gcp/hooks/pubsub.py
super().__init__(gcp_conn_id, delegate_to=delegate_to)
self.num_retries = self._get_field('num_retries', 5) # type: int

def get_conn(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there are type annotations in public methods, do we need type hints as well?

Copy link
Member

@mik-laj mik-laj Aug 17, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Google API Client library (discovery API) does not have valid annotations, because types are automatically generated at runtime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not intended to make changes to the code. There are no annotations in many places related to GCP, but this month we will try to prepare PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks!

@turbaszek
[AIRFLOW-5200] Move GCP PubSub to core
55a2392 
This commit moves GCP PubSub from contrib to core.
For more information check AIP-21.
@kaxil kaxil merged commit 01995c0 into apache:master Aug 17, 2019
@turbaszek turbaszek deleted the gcp-pub-sub branch September 19, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coufon coufon coufon approved these changes

@mik-laj mik-laj mik-laj left review comments

Assignees
No one assigned
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@turbaszek @mik-laj @coufon @kaxil