Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5292] Allow ECSOperator to tag tasks #5891

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

philipphoffmann
Copy link
Contributor

This commit introduces a parameter for the ECSOperator in order to
pass along tags to any tasks it is running.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@@ -73,6 +73,8 @@ class ECSOperator(BaseOperator):
:type platform_version: str
:param network_configuration: the network configuration for the task
:type network_configuration: dict
:param tags: a list of tags in the form of [{'key': 'tagKey', 'value': 'tagValue'}].
:type tags: list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is how the boto API accepts tags, but might it be easier for users to instead accept a dict as {'tagKey':, 'tagValue'}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, sounds good, changed it

This commit introduces a parameter for the `ECSOperator` in order to
pass along tags to any tasks it is running.
@mik-laj mik-laj added the provider:amazon-aws AWS/Amazon - related issues label Aug 23, 2019
@ashb ashb merged commit 2856dee into apache:master Aug 28, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
This commit introduces a parameter for the `ECSOperator` in order to
pass along tags to any tasks it is running.
ashb pushed a commit that referenced this pull request Oct 11, 2019
This commit introduces a parameter for the `ECSOperator` in order to
pass along tags to any tasks it is running.

(cherry picked from commit 2856dee)
adityav pushed a commit to adityav/airflow that referenced this pull request Oct 14, 2019
This commit introduces a parameter for the `ECSOperator` in order to
pass along tags to any tasks it is running.

(cherry picked from commit 2856dee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants