New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-XXX] Fix webserver link in BREEZE.rst #6013

Merged

jghoman merged 1 commit into apache:master from itstemo:patch-2

Sep 5, 2019

Contributor

itstemo commented Sep 5, 2019

Make sure you have checked all steps below.

Jira

My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

Here are some details about my PR, including screenshots of any UI changes:

change webserver link to RST syntax
currently, the link resulted in an about:blank#blocked site .

Tests

My PR adds the following unit tests OR does not need testing for this extremely good reason:
doc-change

Commits

My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters (not including Jira issue reference)
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Documentation

In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release


          Fix webserver link in breeze.rst

18efc97

- change webserver link to RST syntax
- link resulted in a `about:blank#blocked` .

Contributor Author

itstemo commented Sep 5, 2019

Member

jghoman commented Sep 5, 2019

+1. Looks good. Thanks, @itstemo! Welcome to Airflow!

jghoman merged commit 55d7e70 into apache:master

jghoman approved these changes

View reviewed changes

Member

potiuk commented Sep 5, 2019

Thanks @itstemo @jghoman ! Seems that someone actually reads the documentation 👍 ! Welcome to the project .

potiuk pushed a commit that referenced this pull request


          Fix webserver link in breeze.rst (#6013)

91a99ca

- change webserver link to RST syntax
- link resulted in a `about:blank#blocked` .

(cherry picked from commit 55d7e70)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment