Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example_trigger_target_dag.py #6136

Closed
wants to merge 1 commit into from
Closed

Update example_trigger_target_dag.py #6136

wants to merge 1 commit into from

Conversation

brunolucatto
Copy link

@brunolucatto brunolucatto commented Sep 17, 2019

[fix] Add provide_context=True in order to make kwargs receive the passed message

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

[fix] Add provide_context=True in order to make kwargs receive the passed message
@kaxil kaxil requested a review from Fokko September 17, 2019 19:06
@kaxil
Copy link
Member

kaxil commented Sep 17, 2019

This has been intentionally removed by some awesome work from @Fokko #5990

@brunolucatto
Copy link
Author

brunolucatto commented Sep 17, 2019

I understand it was intentionally removed, but without it, the example is not working on my airflow. I was really confused since two weeks ago it worked, so I went to the git page and saw these changes. Then, I tried adding it again and it solved the case.

I don't know if this works in other circumstances, but it should definitely be double-checked.

@kaxil
Copy link
Member

kaxil commented Sep 17, 2019

Are you installing Airflow from master? Or just using DAGs?

@brunolucatto
Copy link
Author

I did not install airflow, I have been using it as a tool at work, making DAGs. Actually, I was looking at these examples because I am a beginner, so it really gave me a hard time to figure out what was wrong.

@kaxil
Copy link
Member

kaxil commented Sep 17, 2019

I understand the confusion. You should be checking the example DAGs of the version of Airflow you have installed. For example if you have Airflow 1.10.5 installed, you should look at https://github.com/apache/airflow/tree/1.10.5/airflow/example_dags

@kaxil kaxil closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants